Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use markers for evaluating to comments #2607

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Conversation

yuhan0
Copy link
Contributor

@yuhan0 yuhan0 commented Mar 19, 2019

Fixes a slightly annoying bug with comments appearing in unintended locations
when calling (expensive) async cider-eval-***-to-comment commands on a form,
then making subsequent edits while the evaluation is pending.


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (make test)
  • All code passes the linter (make lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

Thanks!

If you're just starting out to hack on CIDER you might find this section of its
manual
extremely useful.

@bbatsov
Copy link
Member

bbatsov commented Mar 20, 2019

The change seems reasonable to me. Please, document it in the changelog.

@yuhan0
Copy link
Contributor Author

yuhan0 commented Mar 20, 2019

Alright, just edited the changelog.
I skipped the other 2 checkboxes because it's not a user-facing change to include in the manual, and would be quite difficult to write tests for this case.

Fixes a slightly annoying bug with comments appearing in unintended locations
when calling (expensive) async `cider-eval-***-to-comment` commands on a form,
then making subsequent edits while the evaluation is pending.
@bbatsov bbatsov merged commit 0367d63 into clojure-emacs:master Mar 20, 2019
@bbatsov
Copy link
Member

bbatsov commented Mar 20, 2019

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants