Skip to content

Support prismatic schema s/def*. #281

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

tiensonqin
Copy link

We use schema.core/defn a lot, even more than clojure.core/defn.

@expez
Copy link
Member

expez commented Mar 20, 2015

I've copied clojure-match-next-def into my own .emacs for this reason too. Next time we should probably pull this regexp into a var, but I think this is OK as 99.9% of all schema users alias it as s.

@bbatsov
Copy link
Member

bbatsov commented Mar 20, 2015

I don't like this solution. We should look for any namespace prefixed def-something, instead of hardcoding s/. Same thing we do for font-locking.

@tiensonqin
Copy link
Author

I know it's not beautiful, this is more of suggestion. Maybe we could make
the regex to a var that user can reset.
On Mar 20, 2015 8:06 PM, "Bozhidar Batsov" notifications@github.com wrote:

I don't like this solution. We should look for any namespace prefixed
def-something, instead of hardcoding s/. Same thing we do for font-locking.


Reply to this email directly or view it on GitHub.

@bbatsov
Copy link
Member

bbatsov commented Apr 7, 2015

def-something, instead of hardcoding s/. Same thing we do for font-locking.

That'd be an overkill IMO. We just need a regexp that's generic - e.g. any-ns/defanything.

@bbatsov bbatsov closed this in 5d2f48b May 17, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants