-
-
Notifications
You must be signed in to change notification settings - Fork 247
[Fix #310,#311] clojure-expected-ns with src/cljc #312
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
bbatsov
merged 1 commit into
clojure-emacs:master
from
expez:improve-clojure-expected-ns
Jul 29, 2015
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
;;; clojure-mode-util-test.el --- Clojure Mode: util test suite -*- lexical-binding: t; -*- | ||
|
||
;; Copyright (C) 2014-2015 Bozhidar Batsov <bozhidar@batsov.com> | ||
|
||
;; This file is not part of GNU Emacs. | ||
|
||
;; This program is free software; you can redistribute it and/or modify | ||
;; it under the terms of the GNU General Public License as published by | ||
;; the Free Software Foundation, either version 3 of the License, or | ||
;; (at your option) any later version. | ||
|
||
;; This program is distributed in the hope that it will be useful, | ||
;; but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
;; GNU General Public License for more details. | ||
|
||
;; You should have received a copy of the GNU General Public License | ||
;; along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
;;; Commentary: | ||
|
||
;; The unit test suite of Clojure Mode | ||
|
||
;;; Code: | ||
(require 'clojure-mode) | ||
(require 'cl-lib) | ||
(require 'ert) | ||
|
||
(let ((project-dir "/home/user/projects/my-project/") | ||
(clj-file-path "/home/user/projects/my-project/src/clj/my_project/my_ns/my_file.clj") | ||
(project-relative-clj-file-path "src/clj/my_project/my_ns/my_file.clj") | ||
(clj-file-ns "my-project.my-ns.my-file")) | ||
|
||
(ert-deftest project-relative-path () | ||
:tags '(utils) | ||
(cl-letf (((symbol-function 'clojure-project-dir) (lambda () project-dir))) | ||
(should (string= (clojure-project-relative-path clj-file-path) | ||
project-relative-clj-file-path)))) | ||
|
||
(ert-deftest expected-ns () | ||
:tags '(utils) | ||
(cl-letf (((symbol-function 'clojure-project-relative-path) | ||
(lambda (&optional current-buffer-file-name) | ||
project-relative-clj-file-path))) | ||
(should (string= (clojure-expected-ns clj-file-path) clj-file-ns))))) | ||
|
||
(provide 'clojure-mode-util-test) | ||
|
||
;; Local Variables: | ||
;; indent-tabs-mode: nil | ||
;; End: | ||
|
||
;;; clojure-mode-util-test.el ends here |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out this implementation is problematic. See clojure-emacs/cider#1215
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix solves the problematic namespaces for 99.9% of affected projects. Let's solve one problem at a time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned this mostly because if we have the same function here, there'll be little point in fixing the problem in cider. Anyways, that's not terribly important right now.