Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Some paths in "Compile From Source" are off a bit #29

Open
sogaiu opened this issue Jan 7, 2024 · 1 comment
Open

Some paths in "Compile From Source" are off a bit #29

sogaiu opened this issue Jan 7, 2024 · 1 comment

Comments

@sogaiu
Copy link

sogaiu commented Jan 7, 2024

As pointed out in #27, some paths for the "Compile From Source" instructions are off for both Linux and macOS.

For example, for Linux I currently see:

mkdir -p dist
cc -c -I./src src/parser.c -o "parser.o"
cc -fPIC -shared src/parser.o -o "dist/libtree-sitter-clojure.so"

The second cc invocation refers to a .o that's not likely to exist from just following the instructions. Likely to lead to a better result might be:

mkdir -p dist
cc -c -I./src src/parser.c -o "src/parser.o"
cc -fPIC -shared src/parser.o -o "dist/libtree-sitter-clojure.so"

That is, have the first cc invocation put the .o file in the src subdirectory.

A similar situation holds for the current macOS instructions.

One way to amend those might be:

mkdir -p dist
cc -c -I./src src/parser.c -o "src/parser.o"
cc -fPIC -shared src/parser.o -o "dist/libtree-sitter-clojure.dylib"
@dannyfreeman
Copy link
Contributor

Now that Emacs compiles from source for you I may remove these instructions and instead link to somewhere else that has them instead.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants