Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update macOS compile from source directions #27

Closed
wants to merge 1 commit into from

Conversation

luandy64
Copy link

Running the instructions before this change resulted in the following error

$ mkdir -p dist
$ cc -c -I./src src/parser.c -o "parser.o"
cc -fPIC -shared src/parser.o -o "dist/libtree-sitter-clojure.dylib"
$ cc -fPIC -shared src/parser.o -o "dist/libtree-sitter-clojure.dylib"
clang: error: no such file or directory: 'src/parser.o'
clang: error: no input files

Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • You've run M-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

Thanks!

Running the instructions before this change resulted in the following error

```bash
$ mkdir -p dist
$ cc -c -I./src src/parser.c -o "parser.o"
cc -fPIC -shared src/parser.o -o "dist/libtree-sitter-clojure.dylib"
$ cc -fPIC -shared src/parser.o -o "dist/libtree-sitter-clojure.dylib"
clang: error: no such file or directory: 'src/parser.o'
clang: error: no input files
```
@luandy64
Copy link
Author

luandy64 commented Jan 5, 2024

Closing for inactivity

@luandy64 luandy64 closed this Jan 5, 2024
@sogaiu
Copy link

sogaiu commented Jan 7, 2024

A similar thing may apply to the current Linux instructions:

mkdir -p dist
cc -c -I./src src/parser.c -o "parser.o"
cc -fPIC -shared src/parser.o -o "dist/libtree-sitter-clojure.so"

There's another way the instructions could be tweaked, which is to output to the current directory instead of under src, though may be that's kind of an odd thing to do.

In any case, perhaps it would be better if both sets of instructions were updated.

A peripheral remark to maintainers -- don't know if it's worth mentioning in the README but I think it's possible to build an appropriate shared library using tree-sitter-module.


On a side note, it doesn't seem so useful to me to close this PR as having it open might make it easier to locate for folks who have encoutered a similar situation or are interested in knowing what kinds of PRs are in the pipeline.

Though may be it's more useful for there to be an issue at this point...

Update: I've made #29

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants