Skip to content

Add customization option to disable markdown syntax highlighting #59

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

rrudakov
Copy link
Contributor

Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • You've run M-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

Thanks!


I would like to introduce a new customization option to disable inline markdown.

After working for some time with clojure-ts-mode on relatively big project I noticed some problems with it. Markdown syntax highlighting is not accurate (note closing backtick has different color in different docstrings):

image

Also having it enabled sometimes introduces memory leaks. Emacs hangs and consumes all available RAM. Unfortunately I couldn't figure out a reliable recipe to reproduce the memory leak.

@bbatsov bbatsov merged commit 5794188 into clojure-emacs:main Feb 16, 2025
3 checks passed
@bbatsov
Copy link
Member

bbatsov commented Feb 16, 2025

That's fine by me, but please also open a separate issue about the problems you've encountered, so we won't forget to investigate and fix them eventually.

@rrudakov
Copy link
Contributor Author

That's fine by me, but please also open a separate issue about the problems you've encountered, so we won't forget to investigate and fix them eventually.

Thanks! I'll create an issue shortly.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants