-
Notifications
You must be signed in to change notification settings - Fork 16
Add defcustom for major-mode remapping #64
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Looks good. I noticed |
clojure-ts-mode.el
Outdated
@@ -119,6 +119,18 @@ double quotes on the third column." | |||
:safe #'booleanp | |||
:package-version '(clojure-ts-mode . "0.2.3")) | |||
|
|||
(defcustom clojure-ts-auto-redirect t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps clojure-ts-auto-remap
or clojure-ts-auto-remap-modes
would be slightly better name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've renamed it to clojure-ts-auto-remap
, wasn't sure if it should have a -p
suffix being a boolean? Feel free to change it further (maybe the commands too, clojure-ts-activate
-> clojure-ts-activate-remapping
)
I've removed the commit which uses defcustom setter to trigger activate/deactivate calls on |
Okay, I guess that will do for now. I thought a bit too late that probably those commands shouldn't do anything if |
Good to know, I'll update the code to use it. |
Closes #63
Naming of defcustom / commands open to change, if alright I can go ahead and edit the changelog/Readme
Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdoc
and fixed any warnings in the code you've written.Thanks!