Skip to content

When activation is missing, do not emit a log message #1

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2020
Merged

When activation is missing, do not emit a log message #1

merged 1 commit into from
Dec 12, 2020

Conversation

jpmelos
Copy link
Collaborator

@jpmelos jpmelos commented Dec 11, 2020

If a Flask request doesn't have an active span, it just means that it was initialized via a mechanism that doesn't run before_request, like app.test_request_context or even manually. It is okay and instrumentation still works.

@jpmelos jpmelos self-assigned this Dec 11, 2020
@jpmelos
Copy link
Collaborator Author

jpmelos commented Dec 12, 2020

Ran tests in my local environment and all tests pass.

@jpmelos jpmelos merged commit 30c80fa into closeio-master Dec 12, 2020
@jpmelos jpmelos deleted the fix-flask-activation-missing-log-message branch December 12, 2020 18:00
@jpmelos
Copy link
Collaborator Author

jpmelos commented Dec 12, 2020

Submitted this change upstream in open-telemetry#253.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@jpmelos jpmelos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jpmelos