Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor #2

Merged
merged 12 commits into from
Dec 18, 2020
Merged

Refactor #2

merged 12 commits into from
Dec 18, 2020

Conversation

FuqingWang
Copy link
Contributor

@FuqingWang FuqingWang commented Dec 13, 2020

Some update:

  1. Refactored code into components for easier module management.
  2. switched the app root from index.js to App.js (Optional, but starting with App.js is more like a convention that the react community follows. index.js is more of an application entry point, while app.js is the root of our app tree, where our component hierarchy starts. Generally we don't mess up with the entry point but the app tree)
  3. rename the folder from "Components" to "components". (Also a conventional thing, lower case first letter for component folders. But for actual components we use upper case first letter)

@FuqingWang FuqingWang changed the title Fuqing Refactor Dec 18, 2020
@mfleader
Copy link
Collaborator

mfleader commented Dec 18, 2020

Can you remove package-lock.json in addition to yarn.lock? I want to take them out of version control since we have package.lock.

@FuqingWang
Copy link
Contributor Author

FuqingWang commented Dec 18, 2020

Just removed those package-lock.json and yarn.lock.

@mfleader mfleader merged commit a903a5d into cloud-bulldozer:main Dec 18, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants