Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixing local compose setup #36

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Fixing local compose setup #36

merged 1 commit into from
Oct 2, 2023

Conversation

vishnuchalla
Copy link
Collaborator

@vishnuchalla vishnuchalla commented Oct 2, 2023 •
edited
Loading

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Fixing local-compose.sh for easy local setup.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

Run local-compose.sh and get the UI up and running, if specified with right credentials in toml file.

jtaleric
jtaleric reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm - this is curious -- you needed this to have local-compose work?

@vishnuchalla
Copy link
Collaborator Author

vishnuchalla commented Oct 2, 2023 •
edited
Loading

hm - this is curious -- you needed this to have local-compose work?

Yes. CMD looks like taking endpoints hits as arguments and erroring out at runtime.

@jtaleric
Copy link
Member

jtaleric commented Oct 2, 2023

hm - this is curious -- you needed this to have local-compose work?

Yes. CMD looks like taking endpoints hits as arguments and erroring out at runtime.

odd.. I do not have this issue.. ill ping you directly

jtaleric
jtaleric approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and doesn't break my env -- I never had an issue w/ CMD vs Entrypoint. happy if this helps others.

@jtaleric jtaleric merged commit 999481b into main Oct 2, 2023
@jtaleric jtaleric deleted the local-compose-fix branch October 2, 2023 18:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jtaleric jtaleric jtaleric approved these changes

@athiruma athiruma Awaiting requested review from athiruma

@krishvoor krishvoor Awaiting requested review from krishvoor

@chentex chentex Awaiting requested review from chentex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishnuchalla @jtaleric