Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update README.md #73

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Update README.md #73

merged 1 commit into from
Jan 4, 2024

Conversation

kpouget
Copy link
Contributor

@kpouget kpouget commented Jan 2, 2024

Use the right Containerfile filename

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

This PR updates the README to refer to the right Containerfile in the frontend image build command.

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Use the right `Containerfile` filename
@kpouget
Copy link
Contributor Author

kpouget commented Jan 2, 2024

also, I had to use this base image to the build to pass:

FROM docker.io/library/node:16.20.2-alpine3.18

otherwise:

[2/4] Fetching packages...
error lru-cache@10.1.0: The engine "node" is incompatible with this module. Expected version "14 || >=16.14". Got "16.10.0"

Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kpouget - most of us use the local-compose for local development, glad to see someone fixing up our docs as we haven't done this! Thank you!

@jtaleric jtaleric merged commit 659c0ef into cloud-bulldozer:main Jan 4, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants