Merge pull request #81 from jtaleric/ack-current

acking the 4.18 and 4.19 issues
cloud-bulldozer · Dec 18, 2024 · 3584d8f · 3584d8f
2 parents 9be6b3c + afbef21
commit 3584d8f
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 1 deletion.
diff --git a/ack/4.18_cluster-density_ack.yaml b/ack/4.18_cluster-density_ack.yaml
@@ -0,0 +1,5 @@
+---
+ack: 
+  - uuid: 7f7337aa-cee3-4a36-b154-a7c48ed1fb75
+    metric: etcdCPU_avg
+    reason: "Below 10%"
diff --git a/ack/4.18_crd-scale_ack.yaml b/ack/4.18_crd-scale_ack.yaml
@@ -0,0 +1 @@
+---
diff --git a/ack/4.18_node-density_ack.yaml b/ack/4.18_node-density_ack.yaml
@@ -0,0 +1,5 @@
+---
+ack: 
+  - uuid: 7f7337aa-cee3-4a36-b154-a7c48ed1fb75
+    metric: etcdCPU_avg
+    reason: "Below 10%"
diff --git a/ack/4.19_cluster-density_ack.yaml b/ack/4.19_cluster-density_ack.yaml
@@ -0,0 +1,5 @@
+---
+ack :
+  - uuid: cfae6e1e-8c47-4628-be52-8705c8c64285
+    metric: kubelet_avg
+    reason: "kube-burner change which increased cpu for kubelet, it was reverted."
diff --git a/ack/4.19_crd-scale_ack .yaml b/ack/4.19_crd-scale_ack .yaml
@@ -0,0 +1 @@
+---
diff --git a/ack/4.19_node-density_ack.yaml b/ack/4.19_node-density_ack.yaml
@@ -0,0 +1 @@
+---
diff --git a/pkg/algorithms/edivisive/edivisive.py b/pkg/algorithms/edivisive/edivisive.py
@@ -22,7 +22,7 @@ def _analyze(self):
 
         # Process if we have ack'ed regression
         ackSet = set()
-        if len(self.options["ack"]) > 1 :
+        if len(self.options["ack"]) > 1 and self.options["ackMap"] is not None:
             for ack in self.options["ackMap"]["ack"]:
                 pos = series.find_by_attribute("uuid",ack["uuid"])
                 ackSet.add(str(pos[0]) + "_" + ack["metric"])