Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

cloudbase-init doesn't support cidata label #135

Open
holmanb opened this issue Apr 3, 2024 · 4 comments
Open

cloudbase-init doesn't support cidata label #135

holmanb opened this issue Apr 3, 2024 · 4 comments

Comments

@holmanb
Copy link

holmanb commented Apr 3, 2024

An attempt was made to correct this, however the value passed through to this function is still 'config-2'

'config-2', 'openstack\\latest\\meta_data.json')

We recently got a request to customize cloud-utils due to this.

@holmanb
Copy link
Author

holmanb commented Apr 3, 2024

I just filed a PR for this.

Aside: Gerrit seems to be preventing contributions. I only went through with it because I plan to submit a PR against Nova soon, which also uses it. Learning a new workflow for one-off contributions like this is painful.

@ader1990
Copy link
Member

ader1990 commented Apr 4, 2024

I just filed a PR for this.

Aside: Gerrit seems to be preventing contributions. I only went through with it because I plan to submit a PR against Nova soon, which also uses it. Learning a new workflow for one-off contributions like this is painful.

Hello, thank you for the PR. I know that the Gerrit is not a straightforward experience, we are planning to move to Github in the future. Will update the Gerrit review page with my comments on the fix.

Thank you!

@holmanb
Copy link
Author

holmanb commented Apr 4, 2024

Thanks for the response @ader1990!

It looks like commit 9b17eaf hasn't been released yet, which probably explains why the user has to use the config-2 label.

When is the next cloudbase-init release expected? I'd like to let the user know when they can expect this feature will be available.

Since this is an upcoming feature in cloudbase, I don't think that adding a short-lived workaround to cloud-utils makes sense, so I just rejected the proposal to add arbitrary label names to cloud-utils.

Hello, thank you for the PR. I know that the Gerrit is not a straightforward experience, we are planning to move to Github in the future. Will update the Gerrit review page with my comments on the fix.

Thank you!

+1 Great! :)

@ader1990
Copy link
Member

ader1990 commented Apr 4, 2024

Hello, we have a few small PR backlog to merge first before a new release, but it should happen in the next month or so (already one year since the last release). I will update this issue once a new stable version has been released.

Thank you,
Adrian.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants