cloud-localds supports custom filesystem label #56
Conversation
For using nocloud on windows images bases on cloudbase cloud-init, the image needs "config-2" as label. That's why I have added an option for the fslabel.
Why? Can you point to some docs or code that verify this? I'm unfamiliar with cloudbase. Your proposal shouldn't break anything, so I'm not opposed. Please sign the cla. |
|
I could not get the windows image to work, unless I started to inspect the debug logs from the python code of the cloud-init project. The label seems to be hardcoded here: |
|
@thomas-schultz it looks like they tried to fix this a while back in cloudbase-init, but didn't quite get it right. I just filed a bug, and a PR to get this fixed. |
|
@thomas-schultz what version of cloudbase are you using? It looks like my last comment was incorrect and nocloud actually does support 'cidata' after that PR. |
There was a problem hiding this comment.
@thomas-schultz what version of cloudbase-init are you using?
It looks like my last comment was incorrect and nocloud actually does support 'cidata' after that PR - just not in any released version yet. The commit to cloudbase-init that introduced this feature just hasn't been released yet, which explains why you still see 'config-2' being required.
Since cloudbase-init has support for this feature in an upcoming release, this feature in cloud-utils would be short-lived and not broadly usable, so it's likely not worth maintaining. Therefore, I'm going to reject this change. That said, thank you for contributing!
|
From upstream cloudbase-init regarding the release date containing this feature:
|
For using nocloud on windows images bases on cloudbase cloud-init, the image needs "config-2" as label. That's why I have added an option for the fslabel.