LITE-28409: Adding pagination capability #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akodelia
force-pushed
the
feature/LITE-28409-Add-pagination-to-endpoints
branch
from
c4f94e4 to
c8f6040
Compare
d3rky
suggested changes
Aug 17, 2023
connect_ext_ppr/pagination.py
Outdated
| """ | ||
| paginated = paginate(db, query, params) | ||
| resolve_params(params) | ||
| response.headers['X-Total-Count'] = str(paginated.total) |
There was a problem hiding this comment.
[COD-C] It is not clear why do we need this header. It duplicates the Content-Range value
akodelia
force-pushed
the
feature/LITE-28409-Add-pagination-to-endpoints
branch
from
c8f6040 to
3388460
Compare
d3rky
approved these changes
Aug 17, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.