IMPALA-2729: Support default values for DECIMAL in Avro. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Merged necessary patch from Jansson.
Support '\0' in the middle of string:
akheron/jansson@9c259c0
2. Merged useful fixes from Jansson.
Fix NUL byte check for object keys:
akheron/jansson@4d5aead
json_string_set* functions should set the length too:
akheron/jansson@a76dc45
3. Avro C library parsses string with length info. Old api is not changed.
|
Have run test on private jobs. with IMPALA-3045 change (in code review) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support '\0' in the middle of string:
akheron/jansson@9c259c0
Fix NUL byte check for object keys:
akheron/jansson@4d5aead
json_string_set* functions should set the length too:
akheron/jansson@a76dc45