Skip to content

Add support for MQTT binary mode #147

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
jskeet opened this issue May 24, 2021 · 2 comments
Open

Add support for MQTT binary mode #147

jskeet opened this issue May 24, 2021 · 2 comments
Assignees
@jskeet
Labels
enhancement New feature or request

Comments

@jskeet
Copy link
Contributor

jskeet commented May 24, 2021

We've updated the dependency, so we should be able to do that now.
@jskeet jskeet added the enhancement New feature or request label May 24, 2021
@jskeet jskeet self-assigned this May 24, 2021
@jskeet
Copy link
Contributor Author

jskeet commented Jun 3, 2021

This will be post-2.0.

@jskeet
Copy link
Contributor Author

jskeet commented Jul 30, 2024

This requires us to know whether the client supports MQTT v5 or not, so there's a bit more API design work to be done. Given that no-one has requested it in 3 years, it may not be terribly important. I've got a part-implemented PR which I'll attach here though.

jskeet added a commit to jskeet/sdk-csharp that referenced this issue Jul 30, 2024
@jskeet
Incomplete implementation of MQTT binary mode
5964989 
In some ways this *is* complete - but it assumes a v5 client.
Instead, we should only populate ContentType (and allow binary mode) when using v5.
This probably requires some API design work.

Will fix cloudevents#147 when complete.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@jskeet jskeet

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jskeet