Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Documentation issue with not correct code snippets #173

Closed
alexkhimich opened this issue May 21, 2020 · 2 comments · Fixed by #208
Closed

Documentation issue with not correct code snippets #173

alexkhimich opened this issue May 21, 2020 · 2 comments · Fixed by #208
Labels
good first issue Good for newcomers module/docs Module documentation changes

Comments

@alexkhimich
Copy link

The class names are diff.

const {
  CloudEvent,
  **HTTPReceiever**
} = require("cloudevents-sdk");

// Create a receiver to accept events over HTTP
const receiver = new **HTTPReceiver**();
@lance lance added the module/docs Module documentation changes label May 21, 2020
@lance
Copy link
Member

lance commented May 27, 2020

The 2.0.0 version was released today, resolving this issue.

@lance lance closed this as completed May 27, 2020
@lance
Copy link
Member

lance commented May 27, 2020

Oh wait... this is just referencing a typo. Reopening.

@lance lance reopened this May 27, 2020
@lance lance added the good first issue Good for newcomers label May 30, 2020
lholmquist added a commit to lholmquist/sdk-javascript that referenced this issue Jun 4, 2020
@lholmquist
docs(README): fix example typo
d1b72ea 
fixes cloudevents#173
@lholmquist lholmquist mentioned this issue Jun 4, 2020
Merged
lholmquist added a commit to lholmquist/sdk-javascript that referenced this issue Jun 4, 2020
@lholmquist
docs(README): fix example typo
f11f37d 
fixes cloudevents#173

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lance lance closed this as completed in #208 Jun 4, 2020
lance pushed a commit that referenced this issue Jun 4, 2020
@lholmquist
docs(README): fix example typo (#208)
9857eda 
fixes #173

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers module/docs Module documentation changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(README): fix example typo lholmquist/sdk-javascript
2 participants
@lance @alexkhimich