Skip to content

Wrong order of arguments for HttpReceiver.accept in the documentation #222

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
c-pius opened this issue Jun 12, 2020 · 1 comment · Fixed by #224
Closed

Wrong order of arguments for HttpReceiver.accept in the documentation #222

c-pius opened this issue Jun 12, 2020 · 1 comment · Fixed by #224
Labels
module/docs Module documentation changes

Comments

@c-pius
Copy link

c-pius commented Jun 12, 2020

Receiver Documentation has the wrong order of arguments.

const receivedEvent = receiver.accept(req.body, req.headers);

sdk-javascript/src/lib/bindings/http/http_receiver.ts

Line 48 in 99bb88b

accept(headers: {}, body: {}) : CloudEvent {

@lholmquist
Copy link
Contributor

@c-pius nice catch

lholmquist added a commit to lholmquist/sdk-javascript that referenced this issue Jun 15, 2020
@lholmquist
docs(README): fix wrong order of arguments in the accept example
1887aa4 
fixes cloudevents#222

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lholmquist lholmquist mentioned this issue Jun 15, 2020
Merged
@lance lance added the module/docs Module documentation changes label Jun 15, 2020
lance pushed a commit that referenced this issue Jun 18, 2020
@lholmquist
docs(README): fix wrong order of arguments in the accept example (#224)
850e893 
fixes #222

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
module/docs Module documentation changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(README): fix wrong order of arguments in the accept example lholmquist/sdk-javascript
3 participants
@lance @lholmquist @c-pius