Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Move typedoc-clarity-theme to devDependencies #278

Closed
lance opened this issue Jul 27, 2020 · 0 comments
Closed

Move typedoc-clarity-theme to devDependencies #278

lance opened this issue Jul 27, 2020 · 0 comments
Labels
chore/dependencies Pull requests that update a dependency file

Comments

@lance
Copy link
Member

lance commented Jul 27, 2020

Describe the Bug
The typedoc-clarity-theme dependency is incorrectly in the dependencies section of package.json.

Steps to Reproduce

  1. Look at package.json

Expected Behavior
The dependency should be in devDependencies.
@lance lance added the chore/dependencies Pull requests that update a dependency file label Jul 27, 2020
lholmquist added a commit to lholmquist/sdk-javascript that referenced this issue Jul 28, 2020
@lholmquist
chore: move typedoc them to a dev dependency.
4784692 
fixes cloudevents#278

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lholmquist lholmquist mentioned this issue Jul 28, 2020
Merged
@lance lance closed this as completed in c76dda6 Jul 28, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
chore/dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lance