Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Browser Version of the module is still called cloudevents-sdk #286

Closed
lholmquist opened this issue Jul 29, 2020 · 1 comment · Fixed by #292
Closed

Browser Version of the module is still called cloudevents-sdk #286

lholmquist opened this issue Jul 29, 2020 · 1 comment · Fixed by #292
Labels
module/browser Module capabilities in a browser environment type/bug Something isn't working version/3.x Issues related to the 3.0 release of this library

Comments

@lholmquist
Copy link
Contributor

lholmquist commented Jul 29, 2020 •
edited
Loading

Describe the Bug
The name of the module changed in #260, but the webpack config was never updated, https://github.com/cloudevents/sdk-javascript/blob/master/webpack.config.js

Steps to Reproduce

  1. Create a Browser Application
  2. Bring in the cloudevents-sdk
  3. window[cloudevents-sdk] exists
    3a. Also, the cloudevents-sdk.js file exists in the built bundles folder

Expected Behavior
module name should be cloudevents

Additional context
Since the 3.0.0 release was just released, can we do this change without a major version bump? It is changing the name, so i think it has to be, but 3.x was just released, and the name was changed, so if we release a 3.0.2 soon, we might be able to get it in there without the major bump.
@lance
Copy link
Member

lance commented Jul 30, 2020

if we release a 3.0.2 soon, we might be able to get it in there without the major bump.

Agree - I think we can just consider this a bug and fix it and release a patch version

@lance lance added module/browser Module capabilities in a browser environment type/bug Something isn't working version/3.x Issues related to the 3.0 release of this library labels Jul 30, 2020
lholmquist added a commit to lholmquist/sdk-javascript that referenced this issue Jul 30, 2020
@lholmquist
fix: update browser name to cloudevents.
809da9f 
* This updates the broswer based version to cloudevents.

fixes cloudevents#286

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lholmquist lholmquist mentioned this issue Jul 30, 2020
Merged
@lholmquist lholmquist linked a pull request Jul 30, 2020 that will close this issue
fix: update browser name to cloudevents. #292
Merged
lance pushed a commit that referenced this issue Jul 30, 2020
@lholmquist
fix: update browser name to cloudevents. (#292)
48d182b 
* This updates the broswer based version to cloudevents instead of cloudevents-sdk.

Fixes: #286

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
module/browser Module capabilities in a browser environment type/bug Something isn't working version/3.x Issues related to the 3.0 release of this library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update browser name to cloudevents. lholmquist/sdk-javascript
2 participants
@lance @lholmquist