-
Notifications
You must be signed in to change notification settings - Fork 69
chore: add npm fix command #74
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
The Travis failure is not due to changes in this PR. |
I’m not sure this is really needed. The same result can be had by running |
Where do we document how to run |
@grant I'm not sure if it needs to be documented, since it's in the npm documentation.
But perhaps adding it to the contributor's guide would be a good place. |
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant you should rebase from |
… into grant_npm_fix Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Still would like to run a simple command like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not going to block it for such a minor commit, but stand by my reasoning that it's unnecessary. :)
Since there is a
lint
command, there should be a way to fix easily.