Skip to content

chore: add npm fix command #74

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Apr 29, 2020
Merged

chore: add npm fix command #74

merged 4 commits into from
Apr 29, 2020

Conversation

grant
Copy link
Member

@grant grant commented Apr 29, 2020

Since there is a lint command, there should be a way to fix easily.

@grant grant requested a review from fabiojose April 29, 2020 03:59
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant
Copy link
Member Author

grant commented Apr 29, 2020

The Travis failure is not due to changes in this PR.

@lance
Copy link
Member

lance commented Apr 29, 2020

I’m not sure this is really needed. The same result can be had by running npm run lint — —fix.

@grant
Copy link
Member Author

grant commented Apr 29, 2020

Where do we document how to run npm run lint — —fix? I didn't know about this.

@grant grant mentioned this pull request Apr 29, 2020
@lance
Copy link
Member

lance commented Apr 29, 2020

@grant I'm not sure if it needs to be documented, since it's in the npm documentation.

As of npm@2.0.0, you can use custom arguments when executing scripts. The special option -- is used by getopt to delimit the end of the options. npm will pass all the arguments after the -- directly to your script:

But perhaps adding it to the contributor's guide would be a good place.

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@lance
Copy link
Member

lance commented Apr 29, 2020

@grant you should rebase from master to pull in the Travis-CI code coverage fix. That will re-run the tests and you'll see a successful build.

… into grant_npm_fix

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant grant changed the title feat: add npm fix command chore: add npm fix command Apr 29, 2020
@grant
Copy link
Member Author

grant commented Apr 29, 2020

Still would like to run a simple command like fix instead of lint — —fix which technically makes sense but is not intuitive.

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to block it for such a minor commit, but stand by my reasoning that it's unnecessary. :)

@grant grant merged commit 005d532 into master Apr 29, 2020
@grant grant deleted the grant_npm_fix branch April 29, 2020 20:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants