-
Notifications
You must be signed in to change notification settings - Fork 69
Update examples to latest(2.x) sdk #206
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
1105cb2
to
b26b15b
Compare
looks like i can't add reviewers, so @lance @helio-frota @grant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions, but otherwise LGTM. Thanks!
I think we should wait to land it though until 2.0.2.
Converted to a draft until 2.0.2 lands |
@lholmquist you will need to modify your commits with |
13bc973
to
d764956
Compare
Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
d764956
to
419c508
Compare
I've updated to the 2.0.2 version now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - ty!
This PR starts to update the examples in
examples
to use the latest released cloudevents-sdk(which is 2.x atm)fixes #187