Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: Update references of specific versions to use Latest Supported. #211

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

lholmquist
Copy link
Contributor

fixes #160

Signed-off-by: Lucas Holmquist lholmqui@redhat.com

fixes cloudevents#160

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of very minor nits.

README.md Outdated
@@ -54,7 +54,7 @@ binary or structured format, and determine what version of the CloudEvents
specification you want to send the event as.

By default, the `HTTPEmitter` will emit events over HTTP POST using the
1.0 specification, in binary mode. You can emit 0.3 events by providing
latest supported specification, in binary mode. You can emit version specific events by providing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: "latest supported specification version"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, that makes sense

README.md Outdated Show resolved Hide resolved
@lholmquist
Copy link
Contributor Author

got the nits

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lholmquist lholmquist force-pushed the 160-remove-specific-versions branch from d72acb7 to 2123257 Compare June 8, 2020 18:24
@lance lance merged commit ed1d328 into cloudevents:master Jun 8, 2020
@lance lance mentioned this pull request Jul 7, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate specific version numbers from examples and docs to extent possible
2 participants