Skip to content

docs: improve readme receiver example #309

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2020
Merged

docs: improve readme receiver example #309

merged 1 commit into from
Aug 11, 2020

Conversation

grant
Copy link
Member

@grant grant commented Aug 10, 2020

Improves the README examples for receiving CloudEvents.

Proposed Changes

  • Don't define unused imports
  • Make req and res defined.
  • Small JS syntax changes

Fixes: #308

@grant
docs: improve readme receiver example
1e2c676 
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant grant requested review from lance and lholmquist August 10, 2020 23:35
@grant grant self-assigned this Aug 10, 2020
@lholmquist lholmquist merged commit d590e3a into cloudevents:master Aug 11, 2020
@lholmquist lholmquist mentioned this pull request Aug 11, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 1, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lance lance lance approved these changes

@lholmquist lholmquist lholmquist approved these changes

Assignees

@grant grant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REAMDE sample has req/res undefined
3 participants
@grant @lance @lholmquist