Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove All API's that are labeled "Remove in 4.0" #362

Merged
merged 2 commits into from
Nov 13, 2020

Conversation

lholmquist
Copy link
Contributor

  • This removes all the APIs that were deprecated in the 3.x releases and marked as "remove in 4.0".

  • Also removes any tests associated with those API's

Signed-off-by: Lucas Holmquist lholmqui@redhat.com

Should be merged before 4.0 release. I'll add this issue to the 4.0 proposal

* This removes all the APIs that were deprecated in the 3.x releases and marked as "remove in 4.0".

* Also removes any tests associated with those API's

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lholmquist lholmquist requested review from lance and grant and removed request for lance November 7, 2020 20:16
Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lholmquist lholmquist requested a review from lance November 13, 2020 18:11
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the latency! This lgtm in general, but depending on which lands first, either you or @loopingz will need to adjust, since Emitter is sticking around as a type.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants