Skip to content

chore: release 5.3.2 #470

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 11, 2022
Merged

chore: release 5.3.2 #470

merged 1 commit into from
Feb 11, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 10, 2022

🤖 I have created a release *beep* *boop*

5.3.2 (2022-02-11)

Bug Fixes

  • use isolatedModules: true in tsconfig.json (#469) (b5c0b56)

Miscellaneous


This PR was generated with Release Please.

@grant
Copy link
Member

grant commented Feb 11, 2022

Hi @lance, Are we ready to publish this package?

This fixes #456 that fixes GoogleCloudPlatform/functions-framework-nodejs#425.

@lance
Copy link
Member

lance commented Feb 11, 2022

I would like for #471 to land first if possible.

@grant
Copy link
Member

grant commented Feb 11, 2022

I would like for #471 to land first if possible.

@lance I'll review that PR asap. But I don't think we should require that schema PR to block this. I would simply merge and release this bug fix to unblock us.

Copy link
Member

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approved by me, but checking with @lance.


### Bug Fixes

* use `isolatedModules: true` in tsconfig.json ([#469](https://github.com/cloudevents/sdk-javascript/issues/469)) ([b5c0b56](https://github.com/cloudevents/sdk-javascript/commit/b5c0b56f52dd6119949df1a583b76a48c6e3cec7))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't prevent a bug fix from being rolled out.

@grant
Copy link
Member

grant commented Feb 11, 2022

@lance please confirm you're okay with merging and releasing 5.3.2.

I am fine with #471 creating and releasing 5.4.0.

@lance
Copy link
Member

lance commented Feb 11, 2022

Yes I am okay with it but cannot perform the release right now. If you need it for downstream, I don't want to stand in the way. I just am not able to do it myself at the moment.

@grant grant merged commit 9046b36 into main Feb 11, 2022
@grant grant deleted the release-v5.3.2 branch February 11, 2022 23:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants