Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Investigate usage of thiserror to replace snafu #70

Closed
slinkydeveloper opened this issue Aug 4, 2020 · 2 comments
Closed

Investigate usage of thiserror to replace snafu #70

slinkydeveloper opened this issue Aug 4, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@slinkydeveloper
Copy link
Member

At the moment, to generate library errors, we're using snafu. This library is more powerful than we need, we should investigate https://docs.rs/thiserror as alternative, since it provides only the features we really need

@slinkydeveloper slinkydeveloper added enhancement New feature or request good first issue Good for newcomers labels Aug 4, 2020
@elpiel
Copy link

elpiel commented Oct 27, 2020

If no one is working on this I want to pick it up for hacktoberfest.
I have experience with thiserror and it shouldn't be that hard to replace snafu

@slinkydeveloper
Copy link
Member Author

My only problem with thiserror is that it still does not support no_std environments dtolnay/thiserror#64 , which we plan to support at some point #72 . I suggest you to go forward and start replacing snafu with thiserror so we can compare the two, then we'll figure out the no_std thing

elpiel added a commit to elpiel/sdk-rust that referenced this issue Oct 27, 2020

Verified

This commit was signed with the committer’s verified signature.
elpiel Lachezar Lechev
elpiel added a commit to elpiel/sdk-rust that referenced this issue Oct 27, 2020

Verified

This commit was signed with the committer’s verified signature.
elpiel Lachezar Lechev
elpiel added a commit to elpiel/sdk-rust that referenced this issue Oct 27, 2020

Verified

This commit was signed with the committer’s verified signature.
elpiel Lachezar Lechev
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
elpiel added a commit to elpiel/sdk-rust that referenced this issue Oct 28, 2020

Verified

This commit was signed with the committer’s verified signature.
elpiel Lachezar Lechev
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants