Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

custom_hostname: add support for bundle_method #1298

Merged

Conversation

jacobbednarz
Copy link
Member

Adds support for using BundleMethod in custom hostname certificates.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

changelog detected ✅

@jacobbednarz jacobbednarz force-pushed the custom-hostname-bundle-method branch from ff49320 to ca28650 Compare June 2, 2023 00:44
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #1298 (ca28650) into master (a5dc232) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1298      +/-   ##
==========================================
- Coverage   49.07%   49.07%   -0.01%     
==========================================
  Files         134      134              
  Lines       13091    13090       -1     
==========================================
- Hits         6425     6424       -1     
  Misses       5162     5162              
  Partials     1504     1504              
Impacted Files Coverage Δ
custom_hostname.go 47.24% <ø> (ø)
devices_policy.go 49.47% <ø> (ø)
dns.go 45.05% <ø> (ø)
email_routing_destination.go 66.25% <0.00%> (-0.42%) ⬇️
tunnel.go 41.39% <ø> (ø)

@jacobbednarz jacobbednarz force-pushed the custom-hostname-bundle-method branch from ca28650 to 0fa76cf Compare June 2, 2023 01:01
@jacobbednarz jacobbednarz force-pushed the custom-hostname-bundle-method branch from 0fa76cf to e652911 Compare June 2, 2023 01:05
@jacobbednarz jacobbednarz merged commit 2417b97 into cloudflare:master Jun 2, 2023
@jacobbednarz jacobbednarz deleted the custom-hostname-bundle-method branch June 2, 2023 01:07
@github-actions github-actions bot added this to the v0.69.0 milestone Jun 2, 2023
github-actions bot pushed a commit that referenced this pull request Jun 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

This functionality has been released in v0.69.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants