Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix broken links in cmd/cloudflared/*.go related to running tunnel as a service #1219

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

BWsix
Copy link

@BWsix BWsix commented Mar 27, 2024

This PR updates 3 broken links to document run tunnel as a service.

The one in cmd/cloudflared/updater/update.go can be found by running cloudflared tunnel run:

> cloudflared tunnel run xxxx
2024-03-27T18:21:58Z INF Starting tunnel tunnelID=xxxx
2024-03-27T18:21:58Z INF Version 2024.3.0
2024-03-27T18:21:58Z INF GOOS: linux, GOVersion: go1.21.5-devel-cf, GoArch: amd64
2024-03-27T18:21:58Z INF Settings: xxxx
2024-03-27T18:21:58Z INF cloudflared will not automatically update when run from the shell. To enable auto-updates, run cloudflared as a service: https://developers.cloudflare.com/cloudflare-one/connections/connect-apps/run-tunnel/as-a-service/
^ the broken link is at the end of this line

The other two were found by manually grepping developers.cloudflare.com in the project.

update link to the Mac-specific documentation in Mac-specific code

Co-authored-by: chungthuang <7826979+chungthuang@users.noreply.github.com>
@BWsix
Copy link
Author

BWsix commented Apr 2, 2024

Hi chungthuang, I've updated the link you mentioned

Copy link
Contributor

@chungthuang chungthuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BWsix thank you for fixing the links to the documentation. Can you rebase on the latest changes and we can merge it?

@povilasb
Copy link

povilasb commented Oct 8, 2024

Would be nice to have this merged 🙇‍♂️

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants