Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

update Actions to only run lint once to avoid duplicated warnings #284

Merged
merged 1 commit into from
Mar 5, 2021
Merged

update Actions to only run lint once to avoid duplicated warnings #284

merged 1 commit into from
Mar 5, 2021

Conversation

nickysemenza
Copy link
Contributor

also runs go generate and adds it to Makefile

should help with this noise:
image

@nickysemenza
update Actions to only run lint once to avoid duplicated warnings
db3637d 
also runs `go generate`, and allows CI to run on all branches
@nickysemenza nickysemenza force-pushed the nicky/ci-improvements branch from 1ed2703 to db3637d Compare March 5, 2021 17:09
@nickysemenza nickysemenza marked this pull request as ready for review March 5, 2021 17:11
@nickysemenza nickysemenza requested a review from tanyav2 March 5, 2021 17:33
@nickysemenza nickysemenza merged commit 1c0fca1 into master Mar 5, 2021
@nickysemenza nickysemenza deleted the nicky/ci-improvements branch March 5, 2021 17:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wbl wbl wbl approved these changes

@mihirjham mihirjham mihirjham approved these changes

@lgarofalo lgarofalo Awaiting requested review from lgarofalo

@mitalirawat mitalirawat Awaiting requested review from mitalirawat

@tanyav2 tanyav2 Awaiting requested review from tanyav2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickysemenza @wbl @mihirjham