Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't warn about re-added rules #1029

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Don't warn about re-added rules #1029

merged 1 commit into from
Jul 11, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.62.0-1-gcac486e
Number of rules parsed 4
Number of rules checked 0
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   38.33m ± 3%   38.12m ± 0%  -0.54% (p=0.029 n=10)
CheckRules-4     8.516 ± 2%    8.499 ± 2%       ~ (p=0.912 n=10)
geomean         571.3m        569.2m       -0.37%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.39Mi ± 0%   27.39Mi ± 0%       ~ (p=0.436 n=10)
CheckRules-4    941.4Mi ± 0%   942.4Mi ± 0%       ~ (p=0.247 n=10)
geomean         160.6Mi        160.7Mi       +0.06%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.6k ± 0%   131.6k ± 0%       ~ (p=0.340 n=10)
CheckRules-4    13.95M ± 0%   13.95M ± 0%       ~ (p=0.190 n=10)
geomean         1.355M        1.355M       +0.02%

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (19dbe12) to head (cac486e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1029      +/-   ##
==========================================
- Coverage   94.59%   94.57%   -0.02%     
==========================================
  Files          96       96              
  Lines        9797     9805       +8     
==========================================
+ Hits         9267     9273       +6     
- Misses        375      376       +1     
- Partials      155      156       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit b75f261 into main Jul 11, 2024
20 checks passed
@prymitive prymitive deleted the deps branch July 11, 2024 15:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants