Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix default state handling #1088

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fix default state handling #1088

merged 1 commit into from
Aug 27, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.65.0-3-g983e1fb
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   40.20m ± 1%   40.14m ± 4%       ~ (p=0.912 n=10)
CheckRules-4     8.520 ± 2%    8.535 ± 2%       ~ (p=0.796 n=10)
geomean         585.2m        585.3m       +0.02%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.41Mi ± 0%   27.41Mi ± 0%       ~ (p=0.315 n=10)
CheckRules-4    976.3Mi ± 0%   977.1Mi ± 0%       ~ (p=0.063 n=10)
geomean         163.6Mi        163.6Mi       +0.04%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.9k ± 0%   131.9k ± 0%       ~ (p=0.447 n=10)
CheckRules-4    14.19M ± 0%   14.19M ± 0%       ~ (p=0.063 n=10)
geomean         1.368M        1.368M       +0.02%

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (b2f7bfd) to head (983e1fb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1088   +/-   ##
=======================================
  Coverage   94.89%   94.90%           
=======================================
  Files         102      102           
  Lines       10188    10197    +9     
=======================================
+ Hits         9668     9677    +9     
  Misses        365      365           
  Partials      155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit c8a5339 into main Aug 27, 2024
20 checks passed
@prymitive prymitive deleted the state branch August 27, 2024 09:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants