Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix a crash in vector() parsing #1183

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix a crash in vector() parsing #1183

merged 1 commit into from
Oct 31, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.67.2-1-gf481b96
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   39.89m ± 1%   39.82m ± 4%       ~ (p=0.971 n=10)
CheckRules-4     8.498 ± 2%    8.502 ± 2%       ~ (p=0.853 n=10)
geomean         582.2m        581.8m       -0.07%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.41Mi ± 0%   27.41Mi ± 0%       ~ (p=0.353 n=10)
CheckRules-4    975.1Mi ± 0%   975.2Mi ± 0%       ~ (p=0.684 n=10)
geomean         163.5Mi        163.5Mi       +0.01%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.9k ± 0%   131.9k ± 0%       ~ (p=0.318 n=10)
CheckRules-4    14.15M ± 0%   14.15M ± 0%       ~ (p=0.631 n=10)
geomean         1.366M        1.366M       +0.00%

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.99%. Comparing base (e9cce03) to head (f481b96).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1183   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files         104      104           
  Lines       12559    12561    +2     
=======================================
+ Hits        11930    11932    +2     
  Misses        480      480           
  Partials      149      149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit dd9cea9 into main Oct 31, 2024
20 checks passed
@prymitive prymitive deleted the vector branch October 31, 2024 15:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants