dns: do not parse JSON when response is not ok

cloudflare · Jan 14, 2025 · 1578eaf · 1578eaf
1 parent 8cb7ffd
commit 1578eaf
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/node/internal/internal_dns_client.ts b/src/node/internal/internal_dns_client.ts
@@ -71,10 +71,15 @@ export async function sendDnsRequest(
       },
       method: 'GET',
     });
+    if (!response.ok) {
+      throw new DnsError(name, errorCodes.BADRESP, syscall);
+    }
     // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     json = await response.json();
-  } catch {
-    throw new DnsError(name, errorCodes.BADQUERY, syscall);
+  } catch (e) {
+    throw e instanceof DnsError
+      ? e
+      : new DnsError(name, errorCodes.BADQUERY, syscall);
   }
 
   if ('error' in json) {