fix invalid invocation on getRandomValues() (#2730)

cloudflare · Sep 18, 2024 · 20f3a42 · 20f3a42
1 parent 31b17c8
commit 20f3a42
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/src/node/crypto.ts b/src/node/crypto.ts
@@ -4,8 +4,7 @@
 //
 import { ERR_METHOD_NOT_IMPLEMENTED } from 'node-internal:internal_errors';
 
-// eslint-disable-next-line @typescript-eslint/unbound-method
-export const getRandomValues = crypto.getRandomValues;
+export const getRandomValues = crypto.getRandomValues.bind(crypto);
 export const subtle = crypto.subtle;
 export const webcrypto = crypto;
 

diff --git a/src/workerd/api/node/tests/crypto_random-test.js b/src/workerd/api/node/tests/crypto_random-test.js
@@ -413,3 +413,27 @@ export const timingSafeEqualTest = {
     timingSafeEqual(new Uint8Array(1), new Uint8Array(1));
   },
 };
+
+// Ref: https://github.com/cloudflare/workerd/issues/2716
+export const getRandomValuesIllegalInvocation = {
+  async test() {
+    const crypto = await import('node:crypto');
+    {
+      // The following assertion doesn't fail as of Node.js v20.17.0
+      const getRandomValues = crypto.getRandomValues;
+      strictEqual(getRandomValues(new Uint8Array(6)).length, 6);
+    }
+    throws(
+      () => {
+        // This ensures that we are replicating Node.js behavior as of v20.17.0
+        const getRandomValues = crypto.webcrypto.getRandomValues;
+        strictEqual(getRandomValues(new Uint8Array(6)).length, 6);
+      },
+      {
+        name: 'TypeError',
+        message: /Illegal invocation/,
+      }
+    );
+    strictEqual(crypto.getRandomValues(new Uint8Array(6)).length, 6);
+  },
+};