Skip to content

Commit

Permalink
[CI] Fix minor dependency vulnerability, fix CLA job running when clo…
Browse files Browse the repository at this point in the history
…sing a PR

- GitHub warns about an outdated dependency (idna Rust crate) being vulnerable.
  This is only used as a transitive dependency in a sample however – update
  Rust deps for the sample to fix this.
- The CLA check CI job ran when closing a PR so far, leading to a confusing
  comment when closing a PR that would not pass the CLA job even though the
  point of CLA passing is now moot. Accordingly, we should only run the CLA when
  opening or synchronizing a PR.
  • Loading branch information
fhanau committed Jan 29, 2025
1 parent 2cf2f89 commit 458f9bd
Show file tree
Hide file tree
Showing 4 changed files with 558 additions and 189 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/cla.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
issue_comment:
types: [created]
pull_request_target:
types: [opened,closed,synchronize]
types: [opened,synchronize]
merge_group:

jobs:
Expand Down
Binary file added samples/hello-wasm/.README.md.swp
Binary file not shown.
Loading

0 comments on commit 458f9bd

Please # to comment.