Merge pull request #2672 from cloudflare/yagiz/enable-zlib-test

enable zlib test
cloudflare · Sep 9, 2024 · 962b5f7 · 962b5f7
2 parents d440704 + 2c4ff6e
commit 962b5f7
Showing 1 changed file with 18 additions and 19 deletions.
diff --git a/src/workerd/api/node/tests/zlib-nodejs-test.js b/src/workerd/api/node/tests/zlib-nodejs-test.js
@@ -2272,25 +2272,24 @@ export const brotli = {
         }
       );
 
-      //TODO(soon): enable this test. We don't throw anything in this situation unfortunately
-      // {
-      //   assert.throws(
-      //     () => {
-      //       zlib.createBrotliCompress({
-      //         params: {
-      //           // This is a boolean flag
-      //           [zlib.constants.BROTLI_PARAM_DISABLE_LITERAL_CONTEXT_MODELING]:
-      //             42,
-      //         },
-      //       });
-      //     },
-      //     {
-      //       code: 'ERR_ZLIB_INITIALIZATION_FAILED',
-      //       name: 'Error',
-      //       message: 'Initialization failed',
-      //     }
-      //   );
-      // }
+      {
+        assert.throws(
+          () => {
+            zlib.createBrotliCompress({
+              params: {
+                // This is a boolean flag
+                [zlib.constants.BROTLI_PARAM_DISABLE_LITERAL_CONTEXT_MODELING]:
+                  42,
+              },
+            });
+          },
+          {
+            code: 'ERR_ZLIB_INITIALIZATION_FAILED',
+            name: 'Error',
+            message: 'Initialization failed',
+          }
+        );
+      }
 
       {
         // Test options.flush range