-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
use a specific pnpm version #2555
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just this morning I thought to myself "huh this project isn't using corepack for some reason". And now it's solved.
10d17fa
to
5f39d65
Compare
My goal wasn't to add |
So the preferred workflow is to install any old version of pnpm, then get pnpm to install the right one for us? |
5f39d65
to
d68f6b1
Compare
Preferably, pnpm install |
7f85c93
to
e31dbb3
Compare
e31dbb3
to
08992d8
Compare
08992d8
to
f5fac52
Compare
the syntax for |
Internal CI has passed. Note that the internal build will not be accessing the workerd .npmrc file, it's just the TS and tsconfig changes that are relevant to the internal build, so the last CI run is sufficient. This is ready to merge. |
Currently, we don't have any way of understanding which version of
pnpm
we are using.This pull-request:
packageManager
field that is used both bycorepack
andpnpm
which automatically downloads the correct pnpm version.pnpm
to latest version