Use v8::LocalVector in multiple places #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
reviewed
Aug 25, 2024
|
|
||
| kj::Vector<v8::Local<v8::Value>> argv(args.Length()); | ||
| v8::LocalVector<v8::Value> argv(js.v8Isolate, args.Length()); |
There was a problem hiding this comment.
Nit: Can we have a helper function to convert FunctionCallbackInfo<T> to LocalVector<T>? We can add a todo to simplify it once FunctionCallbackInfo has iterator support?
anonrig
approved these changes
Aug 25, 2024
jasnell
force-pushed
the
jsnell/use-v8-localvector
branch
from
278eb7c to
29dcb39
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8 Local handles aren't really supposed to be heap allocated at all. A short while back v8 introduced a new
v8::LocalVector<T>collection type that more correctly handles the allocation and handling of a collection of locals. Update workerd to use it.