fix the execution order of brotli class #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems this error is only visible on the logs, since error is thrown on the queueMicrotask call.
|
|
@anonrig Yep you found what I was talking about |
anonrig
force-pushed
the
yagiz/regression-test-for-createbrotli
branch
from
fe88b1a to
b122dae
Compare
anonrig
changed the title
|
ok, i think i found it. we should have called the parent class constructor after we initialize the handle. |
npaun
approved these changes
Sep 12, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found the bug. It seems the execution order was wrong. I couldn't find a proper way to test this, but manually running the tests show no
uncaught exception.Fixes #2694