Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[build] Fix Windows build, fix deprecation warnings with Xcode 16 #2732

Merged
merged 2 commits into from
Sep 19, 2024
Merged

[build] Fix Windows build, fix deprecation warnings with Xcode 16 #2732

merged 2 commits into from
Sep 19, 2024

Conversation

fhanau
Copy link
Collaborator

@fhanau fhanau commented Sep 17, 2024

No description provided.

@fhanau fhanau requested review from a team as code owners September 17, 2024 23:07
@fhanau fhanau force-pushed the felix/fix-windows-build branch 2 times, most recently from 79ef67c to ad18984 Compare September 17, 2024 23:54
npaun
npaun approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@npaun npaun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man what a mess

@anonrig
Copy link
Member

anonrig commented Sep 18, 2024

Windows build still appears to be broken

@fhanau
Copy link
Collaborator Author

fhanau commented Sep 18, 2024

Windows build still appears to be broken

$ wget https://github.com/aspect-build/bsdtar-prebuilt/releases/download/v3.7.5/tar_windows_amd64.exe
$ file tar_windows_amd64.exe
tar_windows_amd64.exe: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, stripped

The Windows binary isn't actually a Windows binary. Great!

@npaun
Copy link
Member

npaun commented Sep 18, 2024

Very nice. Windows should have just used ELF anyway.

@fhanau fhanau force-pushed the felix/fix-windows-build branch from ad18984 to 80d66bc Compare September 19, 2024 00:54
@fhanau
[build] Fix Windows build
e1f98c8 
aspect_bazel_lib (and by extension rules_js) has broken dependencies, manually
pull in the fixed version.
@fhanau fhanau force-pushed the felix/fix-windows-build branch from 80d66bc to 058bc60 Compare September 19, 2024 01:07
@fhanau fhanau force-pushed the felix/fix-windows-build branch from 058bc60 to b2f0cd7 Compare September 19, 2024 01:18
@fhanau fhanau merged commit bb0f8a0 into main Sep 19, 2024
13 checks passed
@fhanau fhanau deleted the felix/fix-windows-build branch September 19, 2024 02:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@npaun npaun npaun approved these changes

@jasnell jasnell Awaiting requested review from jasnell jasnell is a code owner automatically assigned from cloudflare/workers-runtime-1

@a-robinson a-robinson Awaiting requested review from a-robinson a-robinson is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fhanau @anonrig @npaun