Fixes to external package loading: use external lock and load stdlib. #3305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom96
force-pushed
the
dominik/use-external-pkg-lock
branch
3 times, most recently
from
8acf491 to
557cf35
Compare
dom96
force-pushed
the
dominik/use-external-pkg-lock
branch
from
557cf35 to
2c97595
Compare
hoodmane
approved these changes
Jan 10, 2025
hoodmane
reviewed
Jan 10, 2025
hoodmane
reviewed
Jan 10, 2025
dom96
force-pushed
the
dominik/use-external-pkg-lock
branch
2 times, most recently
from
d9e1eae to
67f838a
Compare
dom96
force-pushed
the
dominik/use-external-pkg-lock
branch
from
67f838a to
9957619
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review. Still needs a new bundle generated which I will do after review.
Implements changes to use the external package lock (rather than the built-in one) and to fix how we load the stdlib when external package loading is enabled.