New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(node:timers) calling refresh breaks the timers #3361

Merged

vicb merged 1 commit into main from fix/refresh

Jan 20, 2025

Contributor

vicb commented Jan 20, 2025

Calling TImeout#refresh does not update #timer making it impossible to cancel
/refresh the timer.


          fix(node:timers) calling refresh breaks the timers

vicb requested review from a team as code owners

January 20, 2025 08:28

vicb requested review from garrettgu10, Frederik-Baetens and IgorMinar

January 20, 2025 08:28

jasnell approved these changes

View reviewed changes

Contributor Author

vicb commented Jan 20, 2025

Thanks for the review!

vicb merged commit d171c7f into main

15 checks passed

vicb deleted the fix/refresh branch

January 20, 2025 14:49

# for free to join this conversation on GitHub. Already have an account? # to comment

Reviewers

jasnell jasnell approved these changes

garrettgu10 Awaiting requested review from garrettgu10 garrettgu10 is a code owner automatically assigned from cloudflare/workers-runtime-1

Frederik-Baetens Awaiting requested review from Frederik-Baetens Frederik-Baetens is a code owner automatically assigned from cloudflare/workers-runtime-1

IgorMinar Awaiting requested review from IgorMinar IgorMinar is a code owner automatically assigned from cloudflare/workers-frameworks

Labels

None yet