New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

update util.getCallSites() implementation to follow node.js #3381

Merged

anonrig merged 1 commit into main from yagiz/update-get-call-sites-implementation

Jan 21, 2025

Member

anonrig commented Jan 21, 2025

This is an experimental API and just got recently changed.

Latest update: nodejs/node#56584

anonrig requested a review from jasnell

January 21, 2025 15:20

anonrig requested review from a team as code owners

January 21, 2025 15:20

anonrig requested a review from garrettgu10

January 21, 2025 15:20

github-actions bot commented Jan 21, 2025 •

edited

Loading

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

jasnell reviewed

View reviewed changes

src/workerd/api/node/util.h Show resolved Hide resolved

jasnell reviewed

View reviewed changes

src/workerd/api/node/util.h Outdated Show resolved Hide resolved

jasnell reviewed

View reviewed changes

src/workerd/api/node/util.h Outdated Show resolved Hide resolved

anonrig force-pushed the yagiz/update-get-call-sites-implementation branch from 98fbf99 to db0eb48 Compare

January 21, 2025 15:48

anonrig requested a review from a team as a code owner

January 21, 2025 15:48

anonrig requested review from petebacondarwin and jasnell

January 21, 2025 15:48

jasnell reviewed

View reviewed changes

src/node/util.ts Outdated Show resolved Hide resolved

jasnell reviewed

View reviewed changes

src/node/util.ts Outdated Show resolved Hide resolved

jasnell reviewed

View reviewed changes

src/workerd/api/node/util.c++ Show resolved Hide resolved


          update util.getCallSites() implementation to follow node.js

88c84e4

anonrig force-pushed the yagiz/update-get-call-sites-implementation branch from db0eb48 to 88c84e4 Compare

January 21, 2025 16:33

jasnell approved these changes

View reviewed changes

anonrig enabled auto-merge (squash)

January 21, 2025 16:39

anonrig merged commit cbe0cca into main

16 of 17 checks passed

anonrig deleted the yagiz/update-get-call-sites-implementation branch

January 21, 2025 17:10

# for free to join this conversation on GitHub. Already have an account? # to comment

Reviewers

jasnell jasnell approved these changes

garrettgu10 Awaiting requested review from garrettgu10 garrettgu10 is a code owner automatically assigned from cloudflare/workers-runtime-1

petebacondarwin Awaiting requested review from petebacondarwin petebacondarwin is a code owner automatically assigned from cloudflare/workers-frameworks

Labels

None yet