Fix SEEK_END for Python metadatafs #3384
Merged
+30
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
commented
Jan 21, 2025
danlapid
reviewed
Jan 21, 2025
danlapid
approved these changes
Jan 21, 2025
hoodmane
force-pushed
the
hoodmane/seek-metadata-fs
branch
3 times, most recently
from
7036658 to
00db4cb
Compare
danlapid
reviewed
Jan 22, 2025
hoodmane
force-pushed
the
hoodmane/seek-metadata-fs
branch
2 times, most recently
from
479b337 to
a8a7c57
Compare
hoodmane
force-pushed
the
hoodmane/seek-metadata-fs
branch
from
a8a7c57 to
399ce9e
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We calculated the total size of the file in readOnlyFS in a way that only worked for tarfs and not for metadatafs.