DeferredProxyCoroutine::await_transform() perfectly-forwards result #3392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our current implementation of await_transform() requires that we return a result by value, by dint of returning `auto`. An upcoming capnproto patch will change await_transform()'s behavior to just be a pass-through, deferring the actual awaiter construction to a new `operator co_await` implementation. By returning `decltype(auto)`, we become compatible with capnproto both before and after that patch.
kentonv
approved these changes
Jan 22, 2025
harrishancock
added a commit
to capnproto/capnproto
that referenced
this pull request
Jan 22, 2025
This reverts commit 8fc9cb7. This requires landing cloudflare/workerd#3392 first.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current implementation of await_transform() requires that we return a result by value, by dint of returning
auto. An upcoming capnproto patch will change await_transform()'s behavior to just be a pass-through, deferring the actual awaiter construction to a newoperator co_awaitimplementation. By returningdecltype(auto), we become compatible with capnproto both before and after that patch.