-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Roll V8 to 13.3 #3417
Merged
Merged
Roll V8 to 13.3 #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated output of |
fhanau
reviewed
Jan 28, 2025
fhanau
reviewed
Jan 28, 2025
Versions of zlib, absl and ICU (in |
f509c7b
to
a98655d
Compare
- Adjust isolate group creation to allow building with and without shared pointer cage - Update V8 defines in compile_flags.txt based on bazel aquery output – we currently build V8 without perfetto support. Ideally we'd have an external, auto-generated file with the set of definitions that matter for embedders, but for now this needs to be maintained manually. - Fix some of the deprecation warnings from V8 13.3. - Change comment on updating Chromium zlib, this is more of a chore than a necessity. Co-authored-by: Felix Hanau <felix@cloudflare.com>
a98655d
to
9b5d733
Compare
Dropped the |
mar-cf
approved these changes
Jan 30, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.