Minor span tracing improvements #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentonv
reviewed
Feb 10, 2023
ObsidianMinor
force-pushed
the
fixup/tracing-apis
branch
2 times, most recently
from
1a6bddb to
66b2b51
Compare
|
Why do we need to be able to create subspans after the span has ended? I think the original design expected that would never happen. |
|
There's nothing saying it's invalid, and you can technically do it today by making a separate |
|
A real example would probably be something like, operation A spawns operation B, but operation A actually ends before operation B has technically "started" because of runtime shenanigans. |
Warfields
reviewed
May 31, 2023
| @@ -302,22 +303,24 @@ SpanBuilder::~SpanBuilder() noexcept(false) { | |||
| } | |||
|
|
|||
| void SpanBuilder::end() { | |||
There was a problem hiding this comment.
(Optional) We may want a test on the new span behavior in 8d7e51e, to prevent possible regressions in the future.
kentonv
reviewed
Jun 1, 2023
WORKSPACE
Outdated
| type = "tgz", | ||
| urls = ["https://github.com/capnproto/capnproto/tarball/b2afb7f8fe393466a38e2fd2ad98482c34aafcee"], | ||
| urls = ["https://github.com/capnproto/capnproto/tarball/d0f22701fd3e5a95c108ee1bdc0af7f444d67794"], |
kentonv
approved these changes
Jun 1, 2023
Encapsulating the entire span in a state containing the observer and span and setting it null on `end()` prevents the creation of subspans after the span has ended.
ObsidianMinor
force-pushed
the
fixup/tracing-apis
branch
from
66b2b51 to
0d00b63
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't set observer null when ending span
Encapsulating the entire span in a state containing the observer and span and setting it null on
end()prevents the creation of subspans after the span has ended.Add getObserver to SpanBuilder
Switch span tracing APIs to use kj::ConstString